feat(ci): Run a quicker clang-tidy for verification in the CI automatically
#1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisperity
added
enhancement
|
You can see an example execution of the "Checks" workflow here: https://github.com/whisperity/Contour/actions/runs/4145252988/jobs/7169368342 The ways of how it is triggered is a bit weird. |
|
@whisperity oopsi. there's a merce conflict in |
src/.clang-tidy
Outdated
Comment on lines
81
to
82
| # This is a *verification* check. The configuration **MUST** be kept in sync | ||
| # with .github/codechecker/config-verify.json |
There was a problem hiding this comment.
I am sure I can create a CI check that validates that both are in sync. once this one is merged, i can take care of that (I did it for a few other things already, too. :) )
whisperity
force-pushed
the
codechecker
branch
from
61796c4
to
d6af9fe
Compare
christianparpart
force-pushed
the
codechecker
branch
2 times, most recently
from
42d3385
to
2c71ab3
Compare
christianparpart
force-pushed
the
codechecker
branch
from
0203094
to
d87eb90
Compare
christianparpart
previously approved these changes
Feb 26, 2023
There was a problem hiding this comment.
I've added src/contour/ to the skipfile.txt until the QML branch (#761) is merged.
christianparpart
force-pushed
the
codechecker
branch
from
a659f34
to
52fecb0
Compare
whisperity
commented
Mar 8, 2023
.github/codechecker/skipfile.txt
Outdated
| -*/_deps/sources/termbench-pro-*/* | ||
| -*/_deps/sources/* | ||
| -*/_deps/* | ||
| -*/src/contour/* |
There was a problem hiding this comment.
This effectively disables static analysis for the project as a whole, no?
Signed-off-by: Christian Parpart <christian@parpart.family>
… branch is merged. Signed-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some checks are implemented in Clang-Tidy that can be used to verify style-like requirements that pure syntax-based systems, such as Clang-Format is not capable of.
Adds a new CI job using the CodeChecker action that runs only these verification checkers (and thus quicker than the full-blown static analysis workflow) and explicitly breaks the build if the style things do not match.
(Due to technical reasons with Clang-Tidy configuration, unfortunately, some minor duplication needs to be done between
.clang-tidyand the CodeChecker config file.)