use optional chaining in the type guard for greater safety #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated
is{entryName}
functions are only useful if you're confident that the thing you're passing in is, at least, a fully-fleshed-outEntry
type. But it's possible to not know what exactly you have. In my case, I have a situation where my object is either a string, an unresolved link, or one of three entry types. And in that case the caller ofis{entryName}
will need to do additional checks to make sure it's even safe to call this function, or risk throwing an exception. Better to have the function just behave safely and do its job all the way.As a general practice in TS,
isXYZ
functions should be safe to call with any argument.