Replace $GLOBALS['objPage'] with the page finder

[leofeyer]

TODO

We sometimes override the global page object to replace insert tags, e.g. here:

contao/core-bundle/contao/dca/tl_page.php

Lines 769 to 782 in d23230e

	// Override the global page object, so we can replace the insert tags
	$GLOBALS['objPage'] = $page;
	$title = implode(
	'%s',
	array_map(
	static function ($strVal) {
	return str_replace('%', '%%', System::getContainer()->get('contao.insert_tag.parser')->replaceInline($strVal));
	},
	explode('{{page::pageTitle}}', $layout->titleTag ?: '{{page::pageTitle}} - {{page::rootPageTitle}}', 2)
	)
	);
	$GLOBALS['objPage'] = $origObjPage;

In these cases, we have to push a new request to the request stack instead.

[Toflar]

If the two remaining places also used the PageFinder, we'd have a central place to adjust the code if we ever need to.

[Toflar]

Should this also use the PageFinder?

[leofeyer]

I don‘t think so, because $pageModel can be an integer here, too. @aschempp /cc

[Toflar]

Should this also use the PageFinder?

[leofeyer]

The service is not internal, so we cannot add a dependency. It also does not make sense to inject both the request stack and the page finder, because both provide the page model.