Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matrix): add missing txid to send message call #416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

piksel
Copy link
Member

@piksel piksel commented Nov 21, 2023

The Matrix Client/Server spec requires that the send message endpoint includes a unique transaction id with each request. The matrix service omits this id for some reason, and the original testing server probably allowed this.

This PR adds an incrementing counter as the transaction ID, which should allow it to work with conduit matrix server.

Fixes #415.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3428e5e) 79.12% compared to head (fe44270) 79.24%.

Files Patch % Lines
pkg/services/matrix/matrix_client.go 73.91% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   79.12%   79.24%   +0.11%     
==========================================
  Files         102      102              
  Lines        4488     4480       -8     
==========================================
- Hits         3551     3550       -1     
+ Misses        758      752       -6     
+ Partials      179      178       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piksel piksel marked this pull request as ready for review November 21, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot send notifications through matrix
1 participant