-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci,tests): add workflow to run bootc e2e tests on windows #364
Conversation
@@ -0,0 +1,236 @@ | |||
name: Podman Desktop BootC E2E Nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, missing the copyright headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
DEFAULT_VERSION: '5.0.2' | ||
DEFAULT_URL: 'https://github.com/containers/podman/releases/download/v5.0.2/podman-remote-release-windows_amd64.zip' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to update all extensions when there is a new version of podman included in Podman Desktop ?
shouldn't be part of some data grabbed from podman desktop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the dependency to podman should be externalized to this repository$
this repo should only depend on 'Podman Desktop' thing
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
@benoitf After the review feedback I have changed the workflow to use the podman version used by podman-desktop when triggered on nightly base, and then there is an option to run workflow on demand with podman version to be choose by the user. But the param's value is static, I do think the default value can be extracted dynamically based on what is in podman-desktop. If that is what you meant? |
about your question yes now it grabs the version automatically so I think it's better |
Great, I was not sure first. Also it came to me, we could probably make it default behavior, so it would be incorporated in the pde2e images but still it would be great to have another option to override default podman version from outside. I have filled an issue for this: containers/podman-desktop-e2e#177. |
What does this PR do?
Add nightly/on demand workflow to run bootc e2e tests on windows
Screenshot / video of UI
What issues does this PR fix or reference?
containers/podman-desktop-e2e#172
How to test this PR?
It would require adding scepcial credentials into repo. TBD