Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add audio_to_text and object_detection recipes to the catalog #869

Merged
merged 4 commits into from Apr 17, 2024

Conversation

jeffmaury
Copy link
Contributor

@jeffmaury jeffmaury commented Apr 10, 2024

Fixes #695

What does this PR do?

Add 2 recipes to the catalog

Blocked by:

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

#695

How to test this PR?

Start the 2 new recipes:

Fixes containers#695

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury marked this pull request as ready for review April 16, 2024 16:57
@jeffmaury jeffmaury requested review from benoitf and a team as code owners April 16, 2024 16:57
@jeffmaury jeffmaury requested review from feloy, axel7083 and lstocchi and removed request for feloy April 16, 2024 16:57
@vrothberg
Copy link
Member

I do not see new recipes in the catalog. Am I missing something?

Screenshot 2024-04-17 at 09 34 24

@lstocchi
Copy link
Contributor

I do not see new recipes in the catalog. Am I missing something?

Be sure that you're actually using this PR. I'm running it now and i can see them. Maybe you forgot to build after switching branch?

@vrothberg
Copy link
Member

I verified to be using the right branch and ran yarn install and yarn build before the yarn watch but do not see the recipe. Really strange.

@vrothberg
Copy link
Member

aaaah ... I had to rm -rf ~/.local/share/containers/podman-desktop for it to show up.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully 🏁 Great work!

Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facing this issue on the audio to text. Which audio sample file did you use?
I downloaded a youtube video as WAV and used it

image

Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaaah ... I had to rm -rf ~/.local/share/containers/podman-desktop for it to show up.

I want to raise an important issue (again) justifying why you had to delete the folder, because on my computer too the new recipes was not visible

image

As I mentionned in #771 (comment) and available in #792

If the user at some point imported manually a model, which is the expected behaviour, he will not see new recipes after an update.

Because we have a unique catalog for the models and recipes, and we do not make any difference between user's one vs native. We ended up with a situation where the new recipes you added was not visible in my catalog because I have a copy of an old one.

@vrothberg
Copy link
Member

I used the one from the local clone as Jeff mentioned in the PR description:

for the audio_to_text you can use the jfk.wav that is located in the data folder of the recipe repository

@vrothberg
Copy link
Member

I want to raise an important issue (again).

@axel7083 that's what I must have hit as well.

Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Images in markdown are not showing up

Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the doc where it explains that we must use a 16-bit WAV file i was able to create a custom audio file and use it on the app. Maybe we should add this inside the app itself.
Like Upload an audio file you wish to have translated (it only supports a 16-bit WAV files)

BTW works fine. Just the problem with the images Axel mentioned.

@jeffmaury
Copy link
Contributor Author

Facing this issue on the audio to text. Which audio sample file did you use? I downloaded a youtube video as WAV and used it

image

In the data folder of the recipe repository (see PR description)

@jeffmaury
Copy link
Contributor Author

image

image

Images in markdown are not showing up

Will be addressed in a follow up PR when we will integrate recipes 1.0 as readme have changed on this side

@axel7083
Copy link
Contributor

After reading the doc where it explains that we must use a 16-bit WAV file i was able to create a custom audio file and use it on the app. Maybe we should add this inside the app itself. Like Upload an audio file you wish to have translated (it only supports a 16-bit WAV files)

BTW works fine. Just the problem with the images Axel mentioned.

I opened containers/ai-lab-recipes#280 as this could be easy fixed by the application converting any audio to the expected format

@jeffmaury jeffmaury merged commit 814e21c into containers:main Apr 17, 2024
4 checks passed
@jeffmaury jeffmaury deleted the GH-695 branch April 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check adding more of the sample application
4 participants