Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display status of recipe/model #747

Merged
merged 2 commits into from Mar 29, 2024
Merged

fix: display status of recipe/model #747

merged 2 commits into from Mar 29, 2024

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Mar 29, 2024 •
edited

What does this PR do?

Display the state of an application for a recipe AND a given model, not for the first one found for a recipe.

Screenshot / video of UI

recipe-model.mp4

What issues does this PR fix or reference?

fixes #574

How to test this PR?

  • Start a recipe with a first model
  • switch to another model, the button "Start AI App" should appear
  • start the recipe with the second model
  • navigating to one or other model should display the information of the running app with the selected model (for example the link should point to the good instance - check the port)

@feloy
fix: display status of recipe/model
ed9aa03 
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy requested review from benoitf and a team as code owners March 29, 2024 12:32
@feloy feloy requested review from lstocchi and slemeur March 29, 2024 12:32
benoitf
benoitf approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but looks like it should have a test case

@feloy
test: add unit tests
6634c7f 
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy merged commit 921b41c into containers:main Mar 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@lstocchi lstocchi Awaiting requested review from lstocchi lstocchi is a code owner automatically assigned from containers/podman-desktop-extension-ai-lab-reviewers

@slemeur slemeur Awaiting requested review from slemeur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No confirmation getting displayed to the end user when testing a new model with a recipe
2 participants
@feloy @benoitf