-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(model-services): making row selectable #700
feat(model-services): making row selectable #700
Conversation
nit: you might want to add padding or tweak the title bar slightly, I notice the height is changing and causing the whole page to shift one pixel vertically when the button appears or disappears. |
Thanks for noticing, it will be fixed by #692 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is missing an inprogress prop as when i click on delete i don't understand if it's actually doing something
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
…ainer ids Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
96895a5
to
9e5ba22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Screenshot / video of UI
selectable-row-services.mp4
What issues does this PR fix or reference?
Fixes #699
How to test this PR?