Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model-services): making row selectable #700

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

axel7083
Copy link
Contributor

What does this PR do?

  • Making the rows in the Model Services page selectable
  • Adding delete action for selected items

Screenshot / video of UI

selectable-row-services.mp4

What issues does this PR fix or reference?

Fixes #699

How to test this PR?

  • unit tests cover the new feature

@axel7083 axel7083 requested a review from a team as a code owner March 26, 2024 13:17
@deboer-tim
Copy link

nit: you might want to add padding or tweak the title bar slightly, I notice the height is changing and causing the whole page to shift one pixel vertically when the button appears or disappears.

@axel7083
Copy link
Contributor Author

nit: you might want to add padding or tweak the title bar slightly, I notice the height is changing and causing the whole page to shift one pixel vertically when the button appears or disappears.

Thanks for noticing, it will be fixed by #692

Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is missing an inprogress prop as when i click on delete i don't understand if it's actually doing something

@axel7083
Copy link
Contributor Author

axel7083 commented Mar 27, 2024

I think it is missing an inprogress prop as when i click on delete i don't understand if it's actually doing something

@lstocchi this is not related to this PR, we sadly have the same when deleting a service using the delete button in the action column. There is an issue for that #547

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
…ainer ids

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 force-pushed the feature/selectable-row-services branch from 96895a5 to 9e5ba22 Compare March 27, 2024 09:38
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axel7083 axel7083 enabled auto-merge (squash) March 27, 2024 09:43
@axel7083 axel7083 merged commit 552f502 into containers:main Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(model-services): making row in table selectable
5 participants