Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding breadcrumbs #697

Merged
merged 5 commits into from Mar 26, 2024
Merged

Conversation

axel7083
Copy link
Contributor

What does this PR do?

Adding Breadcrumbs in a similar manner than Podman-Desktop.

Implementation details: Podman-Desktop use a dedicated store to store the last page, however the webview of AI-Studio can and will be destoryed, re-created many time. making it complicated to save the last page nor relevant with the current UI. In this PR, for each page, we can optionally define a lastpage variable, that will display the breadcrumb corresponding.

Screenshot / video of UI

Model Service Details

image

Create Model Service

image

Create Playground

image

Playground Details

image

Recipe details

image

model details

image

What issues does this PR fix or reference?

Fixes #696

How to test this PR?

Navigate in the pages of AI-Studio

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested a review from a team as a code owner March 26, 2024 11:53
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@feloy
Copy link
Contributor

feloy commented Mar 26, 2024

Also fixes #551 ?

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@feloy
Copy link
Contributor

feloy commented Mar 26, 2024

Model Service Details

image

It would be nice to have the name of the model, instead of 'Service Details'

Also, the Playground list page displays a breadcrumb Playgrounds > Playgrounds environments, which is not consistent with other pages at the same level, where there is no breadcrumb.

@axel7083
Copy link
Contributor Author

Model Service Details
image

It would be nice to have the name of the model, instead of 'Service Details'

Also, the Playground list page displays a breadcrumb Playgrounds > Playgrounds environments, which is not consistent with other pages at the same level, where there is no breadcrumb.

I agree, but this should be made in a follow up PR as it changes the name of the pages properties.

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffmaury jeffmaury merged commit 593dd88 into containers:main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(UX): adding Breadcrumbs
3 participants