Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tooltip to model name #662

Merged
merged 1 commit into from Mar 25, 2024
Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Mar 25, 2024

What does this PR do?

Add a tooltip to the model's name in the models list, to be able to see the complete name of the model

What issues does this PR fix or reference?

Part of #479 (#479 (comment))

How to test this PR?

@feloy feloy requested a review from a team as a code owner March 25, 2024 10:39
@slemeur
Copy link
Contributor

slemeur commented Mar 25, 2024

👍

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems formatting is required

Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy force-pushed the fix-479/model-name-tooltip branch from 4a28299 to b681f85 Compare March 25, 2024 11:10
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting wise, LGTM

@feloy feloy merged commit 294066e into containers:main Mar 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants