New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set system prompt at the beginning #625
Conversation
641b3cb
to
202fb01
Compare
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
b69939c
to
b954c4d
Compare
Can't make it to work response is never returned |
Could you please show me what you are doing exactly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking it until I can run it
It seems it is not the good version. The system prompt textarea should appear at the top of the page (see demo on this issue's description) |
Will retry but seems it's because of the window size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the set button but I'm not sure the UI is very intuitive and following the mock up |
Got it working now: I was building on the backend 😡 |
Please tell me if it is intuitive enough, or I can change to the mockup proposed by Axel |
For me it's not intuitive user should only have to enter the system prompt and user prompt and click Send. But maybe I'm biased. Asking Stevan review |
IMO, it should feel like it is facultative, as it is, having the large text area open by default could confuse the user on what he wants to do. We may want to discuss that in the UX call ? @feloy what do you think? |
Yes, good point, I've added it to today's meeting notes. thanks |
replaced by #643 |
What does this PR do?
Screenshot / video of UI
system-prompt.mp4
What issues does this PR fix or reference?
Part of #525
Fixes #617
How to test this PR?