Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set system prompt at the beginning #625

Closed

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Mar 21, 2024

What does this PR do?

Screenshot / video of UI

system-prompt.mp4

What issues does this PR fix or reference?

Part of #525
Fixes #617

How to test this PR?

@feloy feloy requested a review from a team as a code owner March 21, 2024 10:26
@feloy feloy marked this pull request as draft March 21, 2024 10:26
@feloy feloy force-pushed the feat-617/prevent-sys-prompt-change branch from 641b3cb to 202fb01 Compare March 21, 2024 14:33
@feloy feloy marked this pull request as ready for review March 21, 2024 15:00
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy force-pushed the feat-617/prevent-sys-prompt-change branch from b69939c to b954c4d Compare March 21, 2024 15:04
@jeffmaury
Copy link
Contributor

Can't make it to work response is never returned

@feloy
Copy link
Contributor Author

feloy commented Mar 22, 2024

Can't make it to work response is never returned

Could you please show me what you are doing exactly?

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking it until I can run it

@jeffmaury
Copy link
Contributor

Can't make it to work response is never returned

Could you please show me what you are doing exactly?

playground

@feloy
Copy link
Contributor Author

feloy commented Mar 22, 2024

Can't make it to work response is never returned

Could you please show me what you are doing exactly?

It seems it is not the good version. The system prompt textarea should appear at the top of the page (see demo on this issue's description)

@feloy feloy requested a review from jeffmaury March 22, 2024 08:52
@jeffmaury
Copy link
Contributor

Can't make it to work response is never returned

Could you please show me what you are doing exactly?

It seems it is not the good version. The system prompt textarea should appear at the top of the page (see demo on this issue's description)

Will retry but seems it's because of the window size

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on my end 👍
Screenshot 2024-03-22 at 10 30 13

@jeffmaury
Copy link
Contributor

I don't have the set button but I'm not sure the UI is very intuitive and following the mock up

@jeffmaury
Copy link
Contributor

I don't have the set button but I'm not sure the UI is very intuitive and following the mock up

Got it working now: I was building on the backend 😡

@feloy
Copy link
Contributor Author

feloy commented Mar 22, 2024

I don't have the set button but I'm not sure the UI is very intuitive and following the mock up

Got it working now: I was building on the backend 😡

Please tell me if it is intuitive enough, or I can change to the mockup proposed by Axel

@jeffmaury
Copy link
Contributor

I don't have the set button but I'm not sure the UI is very intuitive and following the mock up

Got it working now: I was building on the backend 😡

Please tell me if it is intuitive enough, or I can change to the mockup proposed by Axel

For me it's not intuitive user should only have to enter the system prompt and user prompt and click Send. But maybe I'm biased. Asking Stevan review

@jeffmaury jeffmaury requested a review from slemeur March 22, 2024 10:03
@axel7083
Copy link
Contributor

axel7083 commented Mar 22, 2024

I don't have the set button but I'm not sure the UI is very intuitive and following the mock up

Got it working now: I was building on the backend 😡

Please tell me if it is intuitive enough, or I can change to the mockup proposed by Axel

For me it's not intuitive user should only have to enter the system prompt and user prompt and click Send. But maybe I'm biased. Asking Stevan review

IMO, it should feel like it is facultative, as it is, having the large text area open by default could confuse the user on what he wants to do.

We may want to discuss that in the UX call ? @feloy what do you think?

@feloy
Copy link
Contributor Author

feloy commented Mar 22, 2024

I don't have the set button but I'm not sure the UI is very intuitive and following the mock up

Got it working now: I was building on the backend 😡

Please tell me if it is intuitive enough, or I can change to the mockup proposed by Axel

For me it's not intuitive user should only have to enter the system prompt and user prompt and click Send. But maybe I'm biased. Asking Stevan review

IMO, it should feel like it is facultative, as it is, having the large text area open by default could confuse the user on what he wants to do.

We may want to discuss that in the UX call ? @feloy what do you think?

Yes, good point, I've added it to today's meeting notes. thanks

@feloy
Copy link
Contributor Author

feloy commented Mar 22, 2024

replaced by #643

@feloy feloy closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent modification of the system prompt after having started the playground's discussion
4 participants