Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup information in README.md #569

Merged
merged 3 commits into from Mar 18, 2024
Merged

Add cleanup information in README.md #569

merged 3 commits into from Mar 18, 2024

Conversation

slemeur
Copy link
Contributor

@slemeur slemeur commented Mar 18, 2024

When the user wants to clean the environment after testing the tool, or when things are getting updated - it's easy to get out of sync. The information are there to help the user to cleanup the environment.

Add cleanup information in README.md
@slemeur slemeur requested a review from a team as a code owner March 18, 2024 10:57
Signed-off-by: Stévan Le Meur <1636769+slemeur@users.noreply.github.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you need to squash the commits (or sign-off all of them).

README.md Outdated Show resolved Hide resolved
Co-authored-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Stévan Le Meur <1636769+slemeur@users.noreply.github.com>
@@ -20,6 +20,16 @@ From the Podman Desktop sources folder:
$ yarn watch --extension-folder path-to-extension-sources-folder/packages/backend
```

## Cleaning up resources

We'll be adding a way in AI Lab to let a user cleanup the environment: see issue https://github.com/projectatomic/ai-studio/issues/469.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We'll be adding a way in AI Lab to let a user cleanup the environment: see issue https://github.com/projectatomic/ai-studio/issues/469.
We'll be adding a way in AI Lab to let a user cleanup the environment: see [issue](https://github.com/projectatomic/ai-studio/issues/469).

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you sing off the first commit ?

@slemeur slemeur merged commit 0587c6e into main Mar 18, 2024
4 checks passed
@slemeur slemeur deleted the cleanup-readme branch March 18, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants