New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: using SnippetManager in the Service Details to create code snippet #556
feat: using SnippetManager in the Service Details to create code snippet #556
Conversation
336e4b3
to
e654a05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
{/each} | ||
</select> | ||
{#if selectedVariant !== undefined} | ||
<select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The select should be disable if the language has only one variant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we keep the select, disable it and put a "N/A" for "Not Applicable"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather apply the suggestion of @jeffmaury as displaying N/A
or Not Applicable
could be weird, when we do have a name for the variant. Showing a hint, of the library used generally.
Here is why it look likes when it is disabled when only one variant.
When I try with curl, the path seems incorrect, as I get a 404. The path is |
bd63c0c
to
35d70cb
Compare
Oh nice catch @feloy, thanks for noticing. I fixed it Here is what is resulting when executing the curl command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
35d70cb
to
627a3fe
Compare
What does this PR do?
This PR is using the SnippetManager in the frontend to generate code snippet.
Screenshot / video of UI
snippet-generator.mp4
What issues does this PR fix or reference?
Fixes #555 #403
How to test this PR?