feat: adding @podman-desktop/ui-svelte #510
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
|
I think there is a missing entry in tailwind.config.js to scan svelte and css files from the also maybe need to introduce it after 0.2.0 tag |
benoitf
requested changes
Mar 19, 2024
There was a problem hiding this comment.
it's a good time to introduce it
but it needs two things IMHO
- requires a bump in the version as there was an issue in previous builds
- addition into the tailwind config file like https://github.com/containers/podman-desktop-extension-bootc/blob/main/packages/frontend/tailwind.config.cjs#L26
|
converting to draft as not updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding the
@podman-desktop/ui-sveltelibrary usingnext.Screenshot / video of UI
What issues does this PR fix or reference?
How to test this PR?