Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish list of Models UI #479

Closed
slemeur opened this issue Mar 11, 2024 · 15 comments
Closed

Polish list of Models UI #479

slemeur opened this issue Mar 11, 2024 · 15 comments
Assignees
Milestone

Comments

@slemeur
Copy link
Contributor

slemeur commented Mar 11, 2024

  • icons
  • font styles
  • table and pre-requisites
@slemeur slemeur added this to the 0.3.0 milestone Mar 11, 2024
@feloy feloy self-assigned this Mar 12, 2024
@feloy
Copy link
Contributor

feloy commented Mar 12, 2024

@slemeur could you please point to the mockup you are refering to?

@vrothberg
Copy link
Member

@feloy do you have everything you need or are there open questions?

@feloy
Copy link
Contributor

feloy commented Mar 18, 2024

@feloy do you have everything you need or are there open questions?

I need more information about the icon and table and pre-requisites

  • icon: for the moment, there is no icon field for the models definition in the catalog file ai.json. Do we want to add it?

  • table and pre-requisites: which pre-requisites?

@jeffmaury
Copy link
Contributor

@feloy do you have everything you need or are there open questions?

I need more information about the icon and table and pre-requisites

* icon: for the moment, there is no icon field for the models definition in the catalog file `ai.json`. Do we want to add it?

* table and pre-requisites: which pre-requisites?

Icon could be based on registry

@vrothberg
Copy link
Member

@slemeur PTAL

@slemeur
Copy link
Contributor Author

slemeur commented Mar 21, 2024

  • Would it be possible to take the icons from HF?
  • pre-requisites: would be cpu, gpu, size.

@vrothberg
Copy link
Member

@jeffmaury WDYT?

@jeffmaury
Copy link
Contributor

@jeffmaury WDYT?

Discussed with @slemeur yesterday

@feloy
Copy link
Contributor

feloy commented Mar 22, 2024

As discussed during UX call (22/03):

  • we will display a generic Model icon on each line (we cannot use the Hugging Face icon). The icon could be colorized to differentiate downloaded models from others
  • the cpu/gpu prerequisite is already displayed (HW Compat column)
  • we won't display the size of the file when the model is not downloaded
  • we will display the memory required (this information needs to be added first to the model's information in the catalog)

@slemeur
Copy link
Contributor Author

slemeur commented Mar 25, 2024

Also in the list, I can't see the complete name of the model
Screenshot 2024-03-25 at 11 28 38

At least, we should have a tooltip - better we figure out a solution and use the same pattern with "2 lines" as we have on containers:
Screenshot 2024-03-25 at 11 29 33

IMO, the information which could go on a second line would be:

  • HW Compatibility
  • Registry
  • License

And to be consistent, we would eventually display them using "labels" from the model serving
Screenshot 2024-03-25 at 11 31 24

@slemeur
Copy link
Contributor Author

slemeur commented Mar 25, 2024

Also please use consistent font sizes with the list of containers

@slemeur
Copy link
Contributor Author

slemeur commented Mar 25, 2024

Please keep the size of the model, as it's an important information to know when you are running out of space in your developer workstation - and you want to cleanup things and get some more free space

@feloy
Copy link
Contributor

feloy commented Mar 25, 2024

  • we won't display the size of the file when the model is not downloaded

we won't display the size of the file when the model is not downloaded

This was probably not clear. It has been said to not display the size of the file before the model is downloaded, but we will keep the file size once it is on disk.

@slemeur
Copy link
Contributor Author

slemeur commented Mar 25, 2024

OK perfect! thanks for clarifying

@feloy
Copy link
Contributor

feloy commented Mar 25, 2024

Also please use consistent font sizes with the list of containers

I have created this issue #667. We need to be careful as this can have impact on many other places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants