healthcheck: Add support for --start-interval and bump imagebuilder to v1.2.8

[flouthoc]

healthcheck: Add support for --start-interval and bump imagebuilder to v1.2.8

Docker now supports --start-interval, start interval
is the time between health checks during the start period.

Ref: https://docs.docker.com/reference/dockerfile/#healthcheck

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

healthcheck: Add support for --start-interval and bump`imagebuilder to v1.2.8

Closes: containers/podman#21701

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [flouthoc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[flouthoc]

@Luap99 I think CI is asking me to bump go version in go.mod file due to some of new dependency, for me the binary builds fine with go 1.20, any idea how can i prevent the version bump ?

The diff which CI is asking me to apply

 M go.mod
diff --git a/go.mod b/go.mod
index e8940aa..020af6d 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,8 @@
 module github.com/containers/buildah
 
-go 1.20
+go 1.21
+
+toolchain go1.22.2
 
 require (
 	github.com/containerd/containerd v1.7.13

[Luap99]

github.com/fsouza/go-dockerclient was bumped to go 1.21 so no there is no way to avoid bumping the go version to update this unless you downgrade this dep again.

Anyhow go 1.20 is EOL so updating to 1.21 is possible but we first need to figure out how to deal with the toolchain line because that default behavior is ridiculous. ref: https://github.com/containers/podman/blob/d65f3996dd263eb875be623d1164ce7e9cbdc3bf/go.mod#L6

[flouthoc]

github.com/fsouza/go-dockerclient was bumped to go 1.21 so no there is no way to avoid bumping the go version to update this unless you downgrade this dep again.

Anyhow go 1.20 is EOL so updating to 1.21 is possible but we first need to figure out how to deal with the toolchain line because that default behavior is ridiculous. ref: https://github.com/containers/podman/blob/d65f3996dd263eb875be623d1164ce7e9cbdc3bf/go.mod#L6

@Luap99 Okay I'll keep this PR on hold till then, I don't want to bump buildah to v1.21 before things on podman is sorted out. Pls let me know once podman toolchain issue is resolved since I am not sure when it is gonna be resolved.

[flouthoc]

Tagging @nalind for info.

[flouthoc]

@Luap99 Could you take a look at 7a36a70 and let me know if it looks good then I can add same commit to this PR

[Luap99]

@Luap99 Could you take a look at 7a36a70 and let me know if it looks good then I can add same commit to this PR

No, that will not work as it will break all renovate PRs.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[flouthoc]

I'll rebase this when the issue with golang which is discussed above gets resolved.

[Luap99]

I'll rebase this when the issue with golang which is discussed above gets resolved.

You should be able to rebase now I think.