Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): fix test/tools ginkgo typo #5455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Asutorufa
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

tests/tools/tools.go import wrong ginkgo package name

How to verify it

$ cd tests/tools
$ go mod tidy
go: finding module for package github.com/onsi/ginkgo/ginkgo/v2
go: github.com/containers/buildah/tests/tools imports
	github.com/onsi/ginkgo/ginkgo/v2: module github.com/onsi/ginkgo@latest found (v1.16.5), but does not contain package github.com/onsi/ginkgo/ginkgo/v2

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 3, 2024
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Asutorufa
Once this PR has been reviewed and has the lgtm label, please assign vrothberg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented May 4, 2024

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. stale-pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant