New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: add support for git sources #5438
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danishprakash The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3a3abfc
to
3d0f34a
Compare
aba9551
to
3a83d68
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
da7f372
to
92ed66a
Compare
Quick fly by review looks OK to me, but you have test issues and a rebase is needed. |
You meant packit issues? Because tests seems to be fine afaict |
92ed66a
to
63a08aa
Compare
63a08aa
to
e56d6ea
Compare
Changes LGTM I did a rebase which was required, and now the DCO (signing) test is not passing. Did you forget to sign a recent commit @danishprakash ? |
Signed-off-by: Danish Prakash <contact@danishpraka.sh>
Signed-off-by: Danish Prakash <contact@danishpraka.sh>
e56d6ea
to
a17c037
Compare
I switched git emails recently, that was the issue, fixed now. |
What type of PR is this?
What this PR does / why we need it:
adds support for git sources with the ADD directive
How to verify it
Which issue(s) this PR fixes:
Fixes #4974
Special notes for your reviewer:
Does this PR introduce a user-facing change?