Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update chatapp readme #85

Merged
merged 1 commit into from Mar 19, 2024

Conversation

MichaelClifford
Copy link
Collaborator

Add more details to the chat app readme

@MichaelClifford
Copy link
Collaborator Author

cc @slemeur

@MichaelClifford
Copy link
Collaborator Author

Partially address #84

Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Relative URLs are not supported as this file will be embedded in the recipe catalog but don't know yet how it will be rendered

@MichaelClifford
Copy link
Collaborator Author

@jeffmaury should I replace all the relative links with github urls before merging?

@MichaelClifford MichaelClifford merged commit 6795ba1 into containers:main Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants