Update to containerd 2.0 rc #1545
Draft
+648
−584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
force-pushed
the
update-containerd-2.0
branch
2 times, most recently
from
bce2d3a
to
302a779
Compare
3 tasks
AkihiroSuda
changed the title
dmcgowan
force-pushed
the
update-containerd-2.0
branch
3 times, most recently
from
7e727bc
to
06db6c6
Compare
ktock
reviewed
Apr 24, 2024
Dockerfile
Outdated
| @@ -12,7 +12,7 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| ARG CONTAINERD_VERSION=v1.7.13 | |||
| ARG CONTAINERD_VERSION=v2.0.0-rc.0 | |||
There was a problem hiding this comment.
Could you bump up this to v2.0.0-rc.1?
dmcgowan
force-pushed
the
update-containerd-2.0
branch
from
06db6c6
to
2eef65b
Compare
Use interfaces from 2.0 package Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
update-containerd-2.0
branch
from
2eef65b
to
b3454f8
Compare
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
update-containerd-2.0
branch
from
b3454f8
to
964e33d
Compare
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
ktock
reviewed
May 30, 2024
| FROM golang:1.21.5-bullseye AS golang-base | ||
| FROM golang:1.22.3-bullseye AS golang-base |
There was a problem hiding this comment.
On runc-dev stage (line 81), please use go 1.21 to fix the current CI failure (OCI runtime create failed: runc create failed: unable to start container process: error during container init: read init-p: connection reset by peer: unknown).
Signed-off-by: Derek McGowan <derek@mcg.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a containerd 2.0 tag to use v2 packages. To find broken areas before final release.