Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake IPFS and EStargz tests #2897

Merged
merged 2 commits into from Mar 25, 2024

Conversation

djdongjin
Copy link
Member

@djdongjin djdongjin commented Mar 24, 2024

IPFS related flaky tests have the following error, e.g. in https://github.com/containerd/nerdctl/actions/runs/8412061811/job/23032444940 (error attached below)

I think the change can mitigate this flaky tests to some extends.

Also the other estargz test shouldn't be executed in parallel since it pulls and rmis a common image. (I also saw flaky related to that)

=== RUN   TestIPFS
    ipfs_linux_test.go:162: assertion failed: res.ExitCode is not exitCode: time="2024-03-24T21:11:22Z" level=fatal msg="1 errors:\nconflict: unable to delete ghcr.io/stargz-containers/alpine:3.13-org (must be forced) - image is being used by stopped container e5d04bd64e173db20d5585cd4a6376e8efa6bf6708df0d0b1859bd798c88acbf"
        
--- FAIL: TestIPFS (0.34s)
FAIL cmd/nerdctl.TestIPFS (0.34s)
=== RUN   TestIPFSAddress
    ipfs_linux_test.go:84: IPAddress=['"10.4.0.61"' ]
    ipfs_linux_test.go:87: ip address matches=["10.4.0.61" 10.4.0.61]
    ipfs_linux_test.go:162: assertion failed: res.ExitCode is not exitCode: time="2024-03-24T21:11:23Z" level=fatal msg="1 errors:\nconflict: unable to delete ghcr.io/stargz-containers/alpine:3.13-org (must be forced) - image is being used by stopped container e5d04bd64e173db20d5585cd4a6376e8efa6bf6708df0d0b1859bd798c88acbf"
        
--- FAIL: TestIPFSAddress (0.80s)
FAIL cmd/nerdctl.TestIPFSAddress (0.80s)
=== RUN   TestIPFSCommit
    ipfs_linux_test.go:162: assertion failed: res.ExitCode is not exitCode: time="2024-03-24T21:11:23Z" level=fatal msg="1 errors:\nconflict: unable to delete ghcr.io/stargz-containers/alpine:3.13-org (must be forced) - image is being used by stopped container e5d04bd64e173db20d5585cd4a6376e8efa6bf6708df0d0b1859bd798c88acbf"
        
--- FAIL: TestIPFSCommit (0.24s)
FAIL cmd/nerdctl.TestIPFSCommit (0.24s)
=== RUN   TestIPFSWithLazyPulling
    ipfs_linux_test.go:162: assertion failed: res.ExitCode is not exitCode: time="2024-03-24T21:11:24Z" level=fatal msg="1 errors:\nconflict: unable to delete ghcr.io/stargz-containers/alpine:3.13-org (must be forced) - image is being used by stopped container e5d04bd64e173db20d5585cd4a6376e8efa6bf6708df0d0b1859bd798c88acbf"

@djdongjin djdongjin force-pushed the deflake-ipfs-tests branch 2 times, most recently from d9436bc to fa34a4b Compare March 25, 2024 04:25
@djdongjin djdongjin closed this Mar 25, 2024
@djdongjin djdongjin reopened this Mar 25, 2024
@djdongjin djdongjin closed this Mar 25, 2024
@djdongjin djdongjin reopened this Mar 25, 2024
@djdongjin djdongjin changed the title Deflake IPFS related tests Deflake IPFS and EStargz tests Mar 25, 2024
Signed-off-by: Jin Dong <jin.dong@databricks.com>
Signed-off-by: Jin Dong <jin.dong@databricks.com>
@djdongjin djdongjin marked this pull request as ready for review March 25, 2024 07:27
@AkihiroSuda AkihiroSuda requested a review from ktock March 25, 2024 17:31
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Mar 25, 2024
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Mar 25, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit b668da5 into containerd:main Mar 25, 2024
22 checks passed
@djdongjin djdongjin deleted the deflake-ipfs-tests branch March 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants