Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/api/types: remove dependencies on nerdctl #2892

Merged
merged 1 commit into from Mar 25, 2024
Merged

pkg/api/types: remove dependencies on nerdctl #2892

merged 1 commit into from Mar 25, 2024
+54 −59

Commits on Mar 25, 2024

  1. pkg/api/types: remove dependencies on nerdctl 

    pkg/api/types had a dependency on netutil and imgutil packages. This
would create issues with circular dependencies, e.g. in containerd#2638 imgutil
could not import types due to its dependency on netutil. This change
moves NetworkCreateOptions and RemoteSnapshotterFlags into types to
remove any future circular dependencies.

This should also help us to clean our function headers, since we no
longer need to explode the options struct into many different pieces.

Signed-off-by: David Son <davbson@amazon.com>
    @sondavidb
    sondavidb committed Mar 25, 2024
    Copy the full SHA
    70ee810 View commit details
    Browse the repository at this point in the history