Move image pull args into struct #2891
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdongjin
reviewed
Mar 22, 2024
sondavidb
force-pushed
the
consolidate-image-pull-args
branch
from
d055293
to
174713e
Compare
djdongjin
reviewed
Mar 29, 2024
sondavidb
force-pushed
the
consolidate-image-pull-args
branch
4 times, most recently
from
77e11ab
to
cb5159c
Compare
|
Rebased with main and addressed reviews. Wondering why lint check seems to fail though... |
djdongjin
approved these changes
Mar 30, 2024
sondavidb
force-pushed
the
consolidate-image-pull-args
branch
from
cb5159c
to
c7951ed
Compare
|
Can I just confirm that the lint check failing is unrelated? |
I think it's unrelated. You can rebase which should retrigger the CI. |
sondavidb
force-pushed
the
consolidate-image-pull-args
branch
from
c7951ed
to
02310d8
Compare
|
Rebased Rebase below this fixes lint issues |
Signed-off-by: David Son <davbson@amazon.com>
sondavidb
force-pushed
the
consolidate-image-pull-args
branch
from
02310d8
to
6dd2f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the image pull workflow, the function headers are getting far too large. (imgutil.EnsureImage had 13 required arguments as of the time of this PR.) This change consolidates many of the arguments in
imgutil.PullImageintotypes.ImagePullTypes, and the necessary refactors that come with this change.I did as much pre-processing in
processPullCommandFlagsas possible. So, anything that cannot be declared from the function flags did not fall in the options.Did some basic testing with
makeand running some basic image commands to do a sanity check that functionality remained intact.Very open to suggestions on how to structure this a bit more logically. I made a best effort but a fresh pair of eyes always helps 馃槄