Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake TestRunCustomRootfs by workaround #2367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yankay
Copy link
Contributor

@yankay yankay commented Jul 10, 2023

Attempt to fix #2327 by workaround

The failure is because the nerdctl can not pull all the layers,
and the ctr can do it.

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@fahedouch
Copy link
Member

Thanks, but I don't think that is a good idea to add a dependency to ctr . IMHO we have to investigate why nerdctl do not attempt to fetch correctly layers inside the ci

@fahedouch fahedouch added area/ci e.g., CI failure status/needs-more-information Needs more information from OP labels Jul 10, 2023
@yankay
Copy link
Contributor Author

yankay commented Jul 11, 2023

Thanks @fahedouch

After investigating the issue, the root cause is here:
https://github.com/containerd/containerd/blob/main/pkg/unpack/unpacker.go#L300C14-L300C14
The layer is skipped because the snapshot can be found.

But I have no idea how to fix it now :-)

@fahedouch
Copy link
Member

Thanks @fahedouch

After investigating the issue, the root cause is here: https://github.com/containerd/containerd/blob/main/pkg/unpack/unpacker.go#L300C14-L300C14 The layer is skipped because the snapshot can be found.

But I have no idea how to fix it now :-)

So it is no longer a cli issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure status/needs-more-information Needs more information from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test: content digest sha256:xxx: not found in CI
2 participants