Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nerdctl logs for run without flagD #1947

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix nerdctl logs for run without flagD #1947

wants to merge 1 commit into from

Conversation

fahedouch
Copy link
Member

@fahedouch fahedouch commented Jan 28, 2023 •
edited

fixing #1946

Signed-off-by: fahed dorgaa fahed.dorgaa@gmail.com

@fahedouch
fix nerdctl logs for run without flagD
e5270a1 
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
@fahedouch
Copy link
Member Author

fahedouch commented Jan 28, 2023 •
edited

test fails because of this. when nerdctl run without -d , nerdctl logs should be triggered to print logs to stdout in parallel with writing to log files

@fahedouch fahedouch mentioned this pull request Jan 28, 2023
Open
@fahedouch fahedouch marked this pull request as draft January 28, 2023 20:33
@AkihiroSuda AkihiroSuda modified the milestone: v1.2.0 Jan 28, 2023
@fahedouch fahedouch mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fahedouch @AkihiroSuda