This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Skip node e2e test in travis. #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
force-pushed
the
skip-node-e2e
branch
from
777c9bd
to
91f8f5d
Compare
|
will this be misleading ? Coz on the checks it shows as succeeded. We can remove it and revert it based on history. |
|
@abhi I'm fine with removing it. Will do it then. |
Signed-off-by: Lantao Liu <lantaol@google.com>
Random-Liu
force-pushed
the
skip-node-e2e
branch
from
91f8f5d
to
00c1477
Compare
|
@abhi Done. |
mikebrow
approved these changes
Jan 12, 2018
Will do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node e2e test always timeout in travis, because for free account travis has 50min timeout (see here).
Since we've already run node e2e as presubmit and CI in Kubernetes test infra, we don't need to run it in travis now.
I don't remove the code for now, because we may want to reuse it, e.g. in containerd repo in the future.
Signed-off-by: Lantao Liu lantaol@google.com