Associate all form inputs with labels #5509
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code isn't used since commit 041abe9.
The `manage_languages` variables is never defined when calling the site customization information texts globalize locales partial.
…-languages" or "globalize-locales", but not both
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| <%= text_field_tag :title_or_id, params["title_or_id"], placeholder: t("admin.budget_investments.index.placeholder") %> | ||
| </div> | ||
| <%= label_tag :title_or_id %> | ||
| <%= text_field_tag :title_or_id, params["title_or_id"], placeholder: t("admin.budget_investments.index.placeholder") %> |
There was a problem hiding this comment.
Input field helper is missing an autocomplete attribute. If no autocomplete behaviour is desired, use the value off or nope.
| class Shared::GlobalizeLocalesComponent < ApplicationComponent | ||
| attr_reader :resource, :manage_languages | ||
| use_helpers :first_translation, :first_marked_for_destruction_translation, | ||
| :enabled_locale?, :name_for_locale, :highlight_translation_html_class |
There was a problem hiding this comment.
Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. (https://rubystyle.guide#no-double-indent)
Suggested change
| :enabled_locale?, :name_for_locale, :highlight_translation_html_class | |
| :enabled_locale?, :name_for_locale, :highlight_translation_html_class |
|
|
||
| def first_i18n_content_translation_locale | ||
| if I18nContentTranslation.existing_languages.count == 0 || | ||
| I18nContentTranslation.existing_languages.include?(I18n.locale) |
There was a problem hiding this comment.
Layout/MultilineOperationIndentation: Align the operands of a condition in an if statement spanning multiple lines.
Suggested change
| I18nContentTranslation.existing_languages.include?(I18n.locale) | |
| I18nContentTranslation.existing_languages.include?(I18n.locale) |
javierm
force-pushed
the
labels_everywhere
branch
from
07f84d8
to
82063bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Notes
visitmethod or decide what to do regarding automated tests for accessibility.