Speed optimisations #1071
Draft
Speed optimisations #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is due to breaking changes in the way tests get discovered which effect us
…strings any more. Allwoing to mix Enum, int, and str makes it hard to do the compiled code to do the same thing as the interpreted one. I believe it is better for readability of the user code, the compiler and basically everything between to not allow that. Only int and enum types shall be used.
…Struct (if possible)
…o Container at the end
franzhaas
force-pushed
the
speedOptimisations
branch
2 times, most recently
from
5c76f42
to
2c19955
Compare
one more compiled item...
franzhaas
force-pushed
the
speedOptimisations
branch
from
2c19955
to
1fc5c56
Compare
franzhaas
force-pushed
the
speedOptimisations
branch
from
1ab1dbd
to
49c7c4c
Compare
franzhaas
force-pushed
the
speedOptimisations
branch
from
e20d9aa
to
03fd7ce
Compare
added 8 commits
April 19, 2024 21:11
This reverts commit 66a9f2b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
I have been using construct for a while and engaged in a failed attempt to improve parsing speed in the past. (but I learned a lot trying...)
I believe I found a way to improve parsing speed significantly through several optimisations:
Parsing is now 2-3x faster for my workload (stdf-tamer), and the compiled code is easier to understand and almost usable as a standalone module.
Allowing lambda/functions where normally can only be this expressions, would have made it much easier for me to use the compile feature, and this is included in this PR. I do believe that in some situations this expressions can not replace a function/lambda.
I would like to get some steering input, what of this effort is good/what needs to change before I would like to head on doing documentation and additional test coverage.
Best regards,
Franz