Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #89 - Support mapped listeners #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rgo
Copy link

@rgo rgo commented Aug 27, 2021

Include SSL configuration taking into account KAFKA_LISTENER_SECURITY_PROTOCOL_MAP.

It avoids to have to add the suffix _SLL to your listeners in case you have more than one.

Include SSL configuration taking into account
KAFKA_LISTENER_SECURITY_PROTOCOL_MAP
@rgo
Copy link
Author

rgo commented Aug 27, 2021

I haven't added tests because the test suite seems to be really old (uses DOCKER_MACHINE_NAME env. variable, some old python version below to 3.7).

I could not manage to make it run locally successfully, sorry. 🤷🏻‍♂️

@rgo
Copy link
Author

rgo commented Aug 27, 2021

Is the pipeline working? Trying to check the details, I get a 404 error.

@rgo
Copy link
Author

rgo commented Sep 3, 2021

Hi @rmoff, could you check this out please?

It will fix your note written here:

Note: The script that configures the Docker image uses the listener name to determine whether to include the SSL configuration items. If you want to use SSL, you need to include SSL in your listener name (e.g. LISTENER_BOB_SSL). Thanks to Russ Sayers for pointing this out.

Thanks!

@rgo
Copy link
Author

rgo commented Sep 16, 2021

Hi @addisonhuddy @andrewegel , could you check this please?
Thanks! :)

@rgo
Copy link
Author

rgo commented Sep 23, 2021

Also fixes #100

@rmoff
Copy link
Contributor

rmoff commented Sep 30, 2021

Thanks for this @rgo , let me see if I can get someone to review and merge it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants