New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chain upgrade system tests #501

Draft

pinosu wants to merge 1 commit into upgrade_wasmd_33 from system_tests_upgrade

Contributor

pinosu commented Aug 23, 2023

No description provided.


          Start system tests implementation

fa7ae10

pinosu changed the title ~~Start system tests implementation~~ Add chain upgrade system tests

github-advanced-security bot found potential problems

View reviewed changes

testing/system.go

Comment on lines +541 to +555

+              		go func() {
+              			_ = cmd.Wait()
+              			s.pidsLock.Lock()
+              			defer s.pidsLock.Unlock()
+              			if len(s.pids) == 0 {
+              				return
+              			}
+              			newPids := make([]int, 0, len(s.pids)-1)
+              			for _, p := range s.pids {
+              				if p != cmd.Process.Pid {
+              					newPids = append(newPids, p)
+              				}
+              			}
+              			s.pids = newPids
+              		}()

Check notice

Code scanning / CodeQL

Spawning a Go routine Note

Spawning a Go routine may be a possible source of non-determinism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment