Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to wasmd 0.30.0-rc0 #479

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Upgrade to wasmd 0.30.0-rc0 #479

wants to merge 10 commits into from

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Nov 22, 2022

Upgrade wasmd to v0.30.0-rc0 and ibc to v4.2.0

@pinosu pinosu requested a review from alpe November 24, 2022 11:01
@pinosu pinosu marked this pull request as ready for review November 24, 2022 11:41
@codecov-commenter
Copy link

Codecov Report

Merging #479 (841e492) into main (7cf259d) will increase coverage by 0.00%.
The diff coverage is 84.21%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage   56.67%   56.67%           
=======================================
  Files          73       73           
  Lines        5824     5831    +7     
=======================================
+ Hits         3301     3305    +4     
- Misses       2200     2203    +3     
  Partials      323      323           
Impacted Files Coverage Δ
app/ante.go 51.21% <ø> (ø)
app/test_access.go 0.00% <ø> (ø)
x/poe/keeper/historical_info.go 91.30% <ø> (ø)
x/twasm/contract/incoming_msgs.go 85.10% <ø> (ø)
x/twasm/types/test_fixtures.go 84.44% <72.72%> (-2.62%) ⬇️
app/app.go 87.59% <100.00%> (ø)
x/twasm/keeper/genesis.go 70.58% <100.00%> (+0.43%) ⬆️
x/twasm/types/genesis.go 87.27% <100.00%> (+0.23%) ⬆️

Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not add the ics29 fee middleware in this upgrade but this is ok for me.
The IBC v4 requires a migration when you skip the v2 release. Please add it to be on the safe side.

@@ -397,7 +397,7 @@ func NewTgradeApp(
// Create static IBC router, add app routes, then set and seal it
ibcRouter := porttypes.NewRouter()
ibcRouter.
AddRoute(wasm.ModuleName, wasm.NewIBCHandler(app.twasmKeeper, app.ibcKeeper.ChannelKeeper)).
AddRoute(wasm.ModuleName, wasm.NewIBCHandler(app.twasmKeeper, app.ibcKeeper.ChannelKeeper, app.ibcKeeper.ChannelKeeper)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -3,10 +3,10 @@ module github.com/confio/tgrade
go 1.18

require (
github.com/CosmWasm/wasmd v0.29.1
github.com/CosmWasm/wasmd v0.30.0-rc0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ ^^ Please use Go 1.19

@alpe alpe mentioned this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants