Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add claim rewards cli command. #422

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Add claim rewards cli command. #422

merged 3 commits into from
Jul 18, 2022

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Jul 13, 2022

Resolves #242

@pinosu pinosu requested a review from maurolacy July 13, 2022 12:14
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you create an issue to add support for the engagement contract owner and receiver optional fields?

Comment on lines +52 to +53
Owner *string `json:"owner,omitempty"`
Receiver *string `json:"receiver,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point it would be nice to add support for these two options as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI command to claim rewards
2 participants