Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate PoE pinned code verification #403

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Deactivate PoE pinned code verification #403

merged 1 commit into from
Jun 21, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jun 17, 2022

Do not fail start when unpinned PoE code.
See #402

Unpinned PoE contracts are not likely to happen on the initial phase but in any case this should not prevent a dump/restart scenario

@alpe alpe requested a review from maurolacy June 17, 2022 11:47
@codecov-commenter
Copy link

Codecov Report

Merging #403 (c1fc434) into main (b940960) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   57.50%   57.45%   -0.05%     
==========================================
  Files          73       73              
  Lines        5565     5564       -1     
==========================================
- Hits         3200     3197       -3     
- Misses       2048     2049       +1     
- Partials      317      318       +1     
Impacted Files Coverage Δ
x/poe/bootstrap.go 63.85% <0.00%> (-0.71%) ⬇️

@alpe alpe marked this pull request as ready for review June 20, 2022 07:50
@alpe alpe requested review from pinosu and removed request for maurolacy June 21, 2022 06:41
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@alpe alpe merged commit 7faa3fa into main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants