Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto pin new PoE contract code id after migration #402

Open
alpe opened this issue Jun 17, 2022 · 1 comment
Open

Auto pin new PoE contract code id after migration #402

alpe opened this issue Jun 17, 2022 · 1 comment

Comments

@alpe
Copy link
Contributor

alpe commented Jun 17, 2022

Migration and Pin code id are two separate processes currently. When a PoE contract is migrated though we likely want the new version pinned. Not sure about the old version? It may still be used by other contracts.

Alternatively, we could have a check that ensures that the new code id is pinned and fail migration otherwise.

This case popped up in dump/restart scenario where the PoE contract validation step failed on restart. I am deactivating this hard constraint in VerifyPoEContracts now. It could be activated with this task again!

@maurolacy
Copy link
Contributor

I would say, the new version should be pinned if the old one was.

Not sure that can be done, as it'll require a matching between the new and old instances. Perhaps by contract name? Or perhaps, through an optional migration param, indicating the old code id?

That said, not sure how relevant this is, as I don't know the details of the migration process at the blockchain level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants