Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: add rollingUpdate strategy in caa daemonset #1274

Merged
merged 1 commit into from Jul 31, 2023

Conversation

huoqifeng
Copy link
Contributor

Fixes: #1214

Fixes: confidential-containers#1214

Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
@huoqifeng
Copy link
Contributor Author

huoqifeng commented Jul 31, 2023

I'm verifying the change following this steps:

  • Installed an IKS cluster with 2 nodes
  • Labled the nodes via command kubectl label nodes --all node.kubernetes.io/worker=
  • Deploy PeerPod via commands after fill correct fields in install/overlays/ibmcloud/kustomization.yaml
kubectl apply -k "github.com/confidential-containers/operator/config/default?ref=v0.7.0"
kubectl apply -k "github.com/confidential-containers/operator/config/samples/ccruntime/peer-pods?ref=v0.7.0"
kubectl apply -k install/overlays/ibmcloud
  • Checked the rolling update strategy added as below via command kubectl -n confidential-containers-system get daemonset cloud-api-adaptor-daemonset -o yaml
  updateStrategy:
    rollingUpdate:
      maxSurge: 0
      maxUnavailable: 1
    type: RollingUpdate
  • Changed the image latest tag to another tag in image: quay.io/confidential-containers/cloud-api-adaptor:latest via command kubectl -n confidential-containers-system edit daemonset cloud-api-adaptor-daemonset
  • Watch the daemonset status via command kubectl -n confidential-containers-system get po --watch |grep cloud-api-adaptor-daemonset
# kubectl -n confidential-containers-system get po --watch |grep cloud-api-adaptor-daemonset
cloud-api-adaptor-daemonset-jskdb                 1/1     Running   0          2m59s
cloud-api-adaptor-daemonset-n5m79                 1/1     Running   0          2m57s
cloud-api-adaptor-daemonset-jskdb                 1/1     Terminating   0          3m20s
cloud-api-adaptor-daemonset-jskdb                 0/1     Terminating   0          3m21s
cloud-api-adaptor-daemonset-jskdb                 0/1     Terminating   0          3m21s
cloud-api-adaptor-daemonset-jskdb                 0/1     Terminating   0          3m21s
cloud-api-adaptor-daemonset-2sz5q                 0/1     Pending       0          0s
cloud-api-adaptor-daemonset-2sz5q                 0/1     Pending       0          0s
cloud-api-adaptor-daemonset-2sz5q                 0/1     ContainerCreating   0          0s
cloud-api-adaptor-daemonset-2sz5q                 1/1     Running             0          2s
cloud-api-adaptor-daemonset-n5m79                 1/1     Terminating         0          3m21s
cloud-api-adaptor-daemonset-n5m79                 0/1     Terminating         0          3m22s
cloud-api-adaptor-daemonset-n5m79                 0/1     Terminating         0          3m22s
cloud-api-adaptor-daemonset-n5m79                 0/1     Terminating         0          3m22s
cloud-api-adaptor-daemonset-xbtjr                 0/1     Pending             0          0s
cloud-api-adaptor-daemonset-xbtjr                 0/1     Pending             0          0s
cloud-api-adaptor-daemonset-xbtjr                 0/1     ContainerCreating   0          0s
cloud-api-adaptor-daemonset-xbtjr                 1/1     Running             0          2s

We can see the pod cloud-api-adaptor-daemonset-xbtjr was created after pod cloud-api-adaptor-daemonset-2sz5q running completely.

Copy link
Contributor

@tumberino tumberino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bpradipt bpradipt merged commit 1b3b737 into confidential-containers:main Jul 31, 2023
11 checks passed
@huoqifeng huoqifeng deleted the rollupdate branch August 1, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use operator to update PeerPod components
3 participants