Fix package name based on local sdist archive #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a local sdist as source, the package name of the conda recipe was based on the sdist filename. This used to be the same but since setuptools 69.3.0, the sdist filename is now normalized. For example, if a package name contains a dash, it's converted to underscore. The package name should be extracted from the metadata and not the sdist filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a local sdist as source, the package name of the conda recipe was based on the sdist filename.
This used to be the same (at least as far as I know) but since setuptools 69.3.0, the sdist filename is now normalized.
For example, if a package name contains a dash, it's converted to underscore (for
my-package, the sdist is nowmy_package-1.0.0.tar.gzinstead ofmy-package-1.0.0.tar.gzas before).The initial package name extracted from the filename has to be overwritten with the name retrieved from the metadata.