Remove empty PATH entry on Windows #13903
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the Windows 10 release, Microsoft added an interactive editor for the PATH variable e.g. [the workflow described here](https://learn.microsoft.com/en-us/dotnet/core/install/windows?tabs=net80#no-net-sdk-was-found). This normalizes the PATH entry by appending a `;` at the end of all entries. Here, because we split on the `;`, we'll end up with an empty entry. Later in the activation code, the paths are normalized with `os.path.normpath` which will expand this to `.` which can affect downstream code and can cause users concern since `.` has a special meaning on POSIX based systems.
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #13903 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Windows 10 release, Microsoft added an interactive editor for the PATH variable e.g. the workflow described here. This normalizes the PATH entry by appending a
;at the end of all entries. Here, because we split on the;, we'll end up with an empty entry. Later in the activation code, the paths are normalized withos.path.normpathwhich will expand this to.which can affect downstream code and can cause users concern since.has a special meaning on POSIX based systems.Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?