Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13437 Type Hints & docstrings for conda.core.envs_manager #13817

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Nathann03
Copy link
Contributor

Description

This small PR that adds a docstrings and type hints to conda.core.envs_manager. This change is part of a larger issue: #13437

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?

  • Add / update necessary tests?

  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @Nathann03.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#916), and ping the bot to refresh the PR.

@Nathann03 Nathann03 marked this pull request as ready for review April 19, 2024 06:25
@Nathann03 Nathann03 requested a review from a team as a code owner April 19, 2024 06:25
@travishathaway
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 19, 2024
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my question.

conda/core/envs_manager.py Show resolved Hide resolved
@travishathaway travishathaway enabled auto-merge (squash) April 23, 2024 05:07
Copy link

codspeed-hq bot commented Apr 23, 2024

CodSpeed Performance Report

Merging #13817 will not alter performance

Comparing Nathann03:13437-Conda.core.envs_manager (95033fb) with main (0c38f56)

Summary

✅ 21 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

None yet

3 participants