Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] General cleanup for test_activate.py #13763

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

kenodegard
Copy link
Contributor

Description

This should be one of the last PRs to be split from #13620. Included here are minor edits:

  • removes unused monkeypatch fixtures
  • uses arg unpacking instead of addition
  • replace tempdir with tmp_path
  • consolidates builder assertions to ensure no untested keys slip through, e.g.:
     # converts this:
     builder = activator.build_activate(prefix)
     ...
     assert builder["unset_vars"] == ...
     assert builder["set_vars"] == ...
     assert builder["export_vars"] == ...
     assert builder["activate_scripts"] == ...
     assert builder["deactivate_scripts"] == ...
     
     # into this:
     assert activator.build_activate(prefix) == {
         # "export_path": {},
         "deactivate_scripts": ...,
         "unset_vars": ...,
         "set_vars": ...,
         "export_vars": ...,
         "activate_scripts": ...,
     }

Extends #13760

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 4, 2024
Copy link

codspeed-hq bot commented Apr 4, 2024

CodSpeed Performance Report

Merging #13763 will not alter performance

Comparing kenodegard:test_activate-cleanup (0cd2676) with main (298ca49)

Summary

✅ 21 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏗️ In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants