New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for conda env create -f environment.json
#13745
base: main
Are you sure you want to change the base?
Conversation
We require contributors to sign our Contributor License Agreement and we don't have one on file for @swaldhoer. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#901), and ping the bot to refresh the PR. |
def test_http_json(): | ||
e = get_simple_environment_json() | ||
f = from_file( | ||
"https://raw.githubusercontent.com/swaldhoer/conda/gh-12942/tests/env/support/simple.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be updated before merging.
conda_cli( | ||
*("env", "create"), | ||
f"--prefix={tmp_path}", | ||
"--file=https://raw.githubusercontent.com/swaldhoer/conda/gh-12942/tests/env/support/simple.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be updated before merging.
pre-commit.ci autofix |
CodSpeed Performance ReportMerging #13745 will degrade performances by 66.64%Comparing Summary
Benchmarks breakdown
|
Hi @swaldhoer, Thank you very much for this contribution. Before we can move forward with this pull request review, we need you to have signed our Contributor License Agreement. Have you already done this? I double checked our current list of signatories and was unable to find your name. |
I'll have a look. |
I think this regression comes from the additional https request. |
Description
Add support for
The whole environment thing was very yaml specific (I mean obviously, it was the only supported format 😅) and for sure it will be staying like that, so tried to implement everything in a backwards compatible manner.
I add documentation (again the whole docs are very yaml centric), so I just added it a few points, so that one is able to create an
environment.json
file and create the environment from thatenvironment.json
file.I added some basic tests, however, frankly speaking I am not sure whether these are sufficient.
Fix #12942
Checklist - did you ...
news
directory (using the template) for the next release's release notes?