[WIP] Feat/poetry 1.8.2 1

[romain-intel]

Description

Replaces #636 but refactors commits to make it easier to review. Addresses #613

Still todo:

• proper setup for the environment (needs support for environment markers to properly resolve cross platform)
• fix the failing tests (hash override) -- I am not sure if this is still relevant as well so not 100% sure how to proceed here.
• verification of the small code changes that were done to support the new APIs

[netlify]

✅ Deploy Preview for conda-lock ready!

Name	Link
🔨 Latest commit	630adf8
🔍 Latest deploy log	https://app.netlify.com/sites/conda-lock/deploys/6645dadaed7533000850fed7
😎 Deploy Preview	https://deploy-preview-637--conda-lock.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[maresb]

Thanks so much, the commit structure looks great!

[romain-intel]

I know it's not done fully yet but let me know what you think particularly about the failing test (if I should work to fix it or if the functionality is no longer needed). I am also working on adding markers to properly be able to resolve the environment (so new feature but I guess needed to finish this).

[maresb]

Hi @romain-intel, it looks great so far!

The failing test was recently added in #629 so it'd be great to fix that to ensure no regression. Perhaps @sfinkens could help?

[sfinkens]

I'll have a look (later today)

[sfinkens]

The problem seems to be that _vendor.poetry.core.packages.package.Package.to_dependency() converts PoetryDependencyWithHash to an "ordinary" Dependency. So the hash from the environment file is lost and a new one is obtained from the online repository.

I don't know if it makes sense to just handle this extra case in to_dependency or if there's a more elegant way.

[maresb]

Thanks @sfinkens for the clue!

I think I've fixed it in 630adf8. Could you please review?

[maresb]

Looks like there's one remaining test failure: test_it_uses_pip_repositories_with_env_var_substitution[conda-response_url_without_credentials]. @jacksmith15, is this something you could help with?

[sfinkens]

Thanks @sfinkens for the clue!

I think I've fixed it in 630adf8. Could you please review?

👍 Very elegant solution!