Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conda’s package directories configurable. #328

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Dec 8, 2023

This adds the ability to use D: instead of C: on GitHub hosted Windows runners, to increase the speed of decompression.

See conda/conda-build#5082 (comment) for more information.

This adds the ability to use D: on Windows runners, to increase speed of decompression.
@jezdez jezdez requested a review from a team as a code owner December 8, 2023 21:06
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@goanpeca
Copy link
Member

goanpeca commented Dec 8, 2023

Thanks for this work @jezdez !

Left a couple of minor comments 🚀

README.md Outdated Show resolved Hide resolved
src/conda.ts Outdated Show resolved Hide resolved
src/delete.ts Outdated Show resolved Hide resolved
jezdez and others added 4 commits February 1, 2024 19:14
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@jezdez
Copy link
Member Author

jezdez commented Mar 14, 2024

@conda-incubator/setup-miniconda any takers for another review?

@jaimergp
Copy link
Member

Code looks good!

Are there any issues with cross-drive hardlinking? I think Windows doesn't like creating those junctions over different units (or if the underlying drive is different), so maybe this is ends up becoming a performance hit if the env is not in the same drive.

So, I wonder if:

  • Should we also allow setting envs-dirs so users can request that new environments are created in the same drive?
  • What about the default path for the installation when conda is bootstrapped from Miniconda or Miniforge installers? Should that also be configurable so we can have everything in the same drive?

@jezdez
Copy link
Member Author

jezdez commented Mar 14, 2024

@jaimergp I don't have answers for this at the moment

@jezdez
Copy link
Member Author

jezdez commented Mar 14, 2024

I don't know why npm is adding all that cruft to dist/delete/index.js :(

@dbast
Copy link
Member

dbast commented Mar 14, 2024

I don't know why npm is adding all that cruft to dist/delete/index.js :(

Afaik the reason is: every new function used from a dependency is copied into the index.js (npm run build = ncc = Compile a Node.js project into a single file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants