Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop libcurl 7 variants #244

Merged
merged 2 commits into from Mar 1, 2024
Merged

Conversation

jdblischak
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I removed our dependence on libcurl 7 in our TileDB Cloud environments by building a custom pysam binary for python 3.9, openssl 3, and libcurl 8 (TileDB-Inc/pysam-feedstock#2)

I purposefully didn't bump the build number. I don't think it's necessary to upload new binaries. Yes, the pins for aws_crt_cpp and aws_sdk_cpp were added, but these are the latest versions anyways and were already being installed.

https://anaconda.org/conda-forge/aws-sdk-cpp/files?version=1.11.267
https://anaconda.org/conda-forge/aws-crt-cpp/files?version=0.26.2

Confirming in the latest build log:

    aws-crt-cpp:                   0.26.2-hce0b5c7_6           conda-forge
    aws-sdk-cpp:                   1.11.267-h5606698_1         conda-forge

This reverts commit c0d541b.

(note: but I manually restored the version to the latest 2.20.1)
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jdblischak jdblischak merged commit 1eb0100 into conda-forge:main Mar 1, 2024
8 checks passed
@jdblischak jdblischak deleted the drop-libcurl-7 branch March 1, 2024 17:57
@h-vetinari
Copy link
Member

Thank you for getting to the bottom of this! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nighly feedstock build failed Drop libcurl 7 builds
4 participants