Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source map caching #5689

Closed
wants to merge 2 commits into from
Closed

Source map caching #5689

wants to merge 2 commits into from

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented May 15, 2024

Problem:
Describe the problem being addressed as succinctly as possible.

Fix:
Describe the fix you have made as succinctly as possible.

Commit Details: (< vv pls delete this section if's not relevant)

  • Renamed thing to otherThing
  • Removed cake from fridge-contents.ts
  • Did [other things]

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)

Copy link
Contributor

github-actions bot commented May 15, 2024

Try me

Copy link

relativeci bot commented May 15, 2024

#12500 Bundle Size — 62.12MiB (~-0.01%).

c2a7c05(current) vs 6339ece master#12497(baseline)

Warning

Bundle contains 52 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Improvement 2 improvements
                 Current
#12500
     Baseline
#12497
Improvement  Initial JS 45.2MiB(~-0.01%) 45.2MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 23.17% 22.21%
No change  Chunks 30 30
No change  Assets 33 33
Change  Modules 4284(-0.05%) 4286
No change  Duplicate Modules 517 517
Change  Duplicate Code 31.02%(+0.03%) 31.01%
Improvement  Packages 448(-0.22%) 449
No change  Duplicate Packages 52 52
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#12500
     Baseline
#12497
Improvement  JS 62.11MiB (~-0.01%) 62.12MiB
Improvement  HTML 10.93KiB (-0.37%) 10.97KiB

Bundle analysis reportBranch chore/source-map-cachingProject dashboard

Copy link
Contributor

github-actions bot commented May 15, 2024

Performance test results:
(Chart1)
(Chart2)

@gbalint gbalint closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant