Replace root element of component #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#12467 Bundle Size — 62.13MiB (~+0.01%).
Warning Bundle contains 52 duplicate packages – View duplicate packages Bundle metrics
|
| Current #12467 |
Baseline #12464 |
|
|---|---|---|
 Initial JS |
45.19MiB(~+0.01%) |
45.19MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
22.16% |
21.91% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4276 |
4276 |
| Duplicate Modules |
509 |
509 |
| Duplicate Code |
31.01% |
31.01% |
| Packages |
449 |
449 |
| Duplicate Packages |
52 |
52 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #12467 |
Baseline #12464 |
|
|---|---|---|
| JS |
62.12MiB (~+0.01%) |
62.12MiB |
| HTML |
10.94KiB (-0.34%) |
10.98KiB |
Bundle analysis report Branch fix/replace-root-element Project dashboard
|
Performance test results: |
bkrmendy
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics,
benwolfram and
liady
...ents/navigator/navigator-item/run-in-shard-2-component-picker-context-menu.spec.browser2.tsx
Show resolved
Hide resolved
ruggi
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try it here
Problem
#5464
Fix
Separate the code that replaces elements from the code that inserts elements, and in the new replace code, "surgically" update the element to be replaced.
Commit Details
ReplaceJSXElement, which is specifically geared towards replacing elements. The replacing-related code is removed fromInsertJSXElementmodifyUnderlyingParseSuccessOnlyis added, since it turned out thatmodifyUnderlyingTargetthrows an error if its target element is removed in its callback.Manual Tests:
I hereby swear that: