chore(editor) Remove our console proxy and the console tab #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#12437 Bundle Size — 62.12MiB (-0.66%).
Warning Bundle removed 6 duplicate packages, 52 duplicate packages remaining – View duplicate packages Bundle metrics
|
| Current #12437 |
Baseline #12435 |
|
|---|---|---|
 Initial JS |
45.18MiB(-0.9%) |
45.59MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
26.96% |
21.16% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4276(-2.51%) |
4386 |
| Duplicate Modules |
509(-0.39%) |
511 |
| Duplicate Code |
31.01%(+0.62%) |
30.82% |
| Packages |
449(-4.06%) |
468 |
| Duplicate Packages |
52(-10.34%) |
58 |
Bundle size by type 2 changes 2 improvements
| Current #12437 |
Baseline #12435 |
|
|---|---|---|
| JS |
62.11MiB (-0.66%) |
62.53MiB |
| HTML |
10.94KiB (-0.34%) |
10.98KiB |
Bundle analysis report Branch chore/remove-console-proxy Project dashboard
Rheeseyb
requested review from
gbalint,
seanparsons,
ruggi,
balazsbajorics,
liady and
bkrmendy
|
Performance test results: |
liady
approved these changes
May 14, 2024
seanparsons
reviewed
May 15, 2024
| firstLine.startsWith(ReactRouterAwaitErrorPrefix) | ||
| ) { | ||
| // ...Mark these as having been seen. | ||
| setReactRouterErrorHasBeenLogged(true) |
There was a problem hiding this comment.
In PR #5084 this was added so that if a change caused an exception in something like an <Await> component, that a further change would result in the error being cleared. Does that now work without this logic?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The console pane is useless.
Fix:
Remove it.
Manual Tests:
I hereby swear that:
Fixes #5631