Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Cartouche Style #5668

Merged
merged 19 commits into from
May 15, 2024
Merged

Data Cartouche Style #5668

merged 19 commits into from
May 15, 2024

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented May 13, 2024

  • restyling of the cartouche controls in the inspector, and putting data from external sources is in green instead of purple
  • uploading icons in green and lightgreen to use for data cartouches coming from external sources in light and dark theme
  • undoing a regression so the prop label and + icon correctly show in blue only when it is unset, hovered, or the data menu is open
  • fixing the styling of the list source cartouche control in the navigator
  • fixing the styling of the MapCounter in it's various states in the navigator
  • fixing some incorrectly blue-colored icons in the navigator
Behold the horror After
Screenshot 2024-05-13 at 5 27 18 PM Screenshot 2024-05-14 at 3 13 16 PM
Screenshot 2024-05-13 at 5 26 26 PM Screenshot 2024-05-14 at 3 13 38 PM
Screenshot 2024-05-13 at 5 25 07 PM Screenshot 2024-05-14 at 3 14 48 PM
Screenshot 2024-05-13 at 5 25 29 PM Screenshot 2024-05-14 at 3 14 25 PM
Screenshot 2024-05-13 at 5 24 02 PM Screenshot 2024-05-14 at 3 15 20 PM
Screenshot 2024-05-13 at 5 23 26 PM Screenshot 2024-05-14 at 3 15 40 PM
Screenshot 2024-05-13 at 8 17 47 PM Screenshot 2024-05-14 at 3 20 00 PM
Screenshot 2024-05-13 at 8 16 39 PM Screenshot 2024-05-14 at 3 19 42 PM

Copy link
Contributor

github-actions bot commented May 13, 2024

Try me

Copy link

relativeci bot commented May 13, 2024

#12449 Bundle Size — 62.54MiB (~+0.01%).

2b46016(current) vs 6339ece master#12438(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#12449
     Baseline
#12438
Regression  Initial JS 45.6MiB(~+0.01%) 45.6MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.8% 21.78%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4386 4386
No change  Duplicate Modules 511 511
No change  Duplicate Code 30.82% 30.82%
No change  Packages 468 468
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#12449
     Baseline
#12438
Regression  JS 62.53MiB (~+0.01%) 62.53MiB
Improvement  HTML 10.94KiB (-0.34%) 10.98KiB

Bundle analysis reportBranch cartouche-styleProject dashboard

Copy link
Contributor

github-actions bot commented May 13, 2024

Performance test results:
(Chart1)
(Chart2)

@lankaukk lankaukk marked this pull request as ready for review May 14, 2024 19:37
@lankaukk lankaukk changed the title Cartouche style Data Cartouche tyle May 14, 2024
@lankaukk lankaukk changed the title Data Cartouche tyle Data Cartouche Style May 14, 2024
@lankaukk lankaukk merged commit f53d182 into master May 15, 2024
15 checks passed
@lankaukk lankaukk deleted the cartouche-style branch May 15, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants