Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Element is broken for the root element of a component #5464

Closed
Rheeseyb opened this issue May 2, 2024 · 1 comment · Fixed by #5681
Closed

Replace Element is broken for the root element of a component #5464

Rheeseyb opened this issue May 2, 2024 · 1 comment · Fixed by #5681
Assignees
@liady

Comments

@Rheeseyb
Copy link
Contributor

Rheeseyb commented May 2, 2024 •
edited

If you select the root element of a component and attempt to replace that element (via the navigator or context menu), we will instead add the new element as a child of the component
@bkrmendy bkrmendy self-assigned this May 14, 2024
@balazsbajorics
Copy link
Contributor

balazsbajorics commented May 15, 2024 •
edited

from https://discord.com/channels/647102474519576589/1200387323884490812/1240281642602594315

btw EP.parentPath is already unsafe if we call it for the root element of a component, because it will just happily chop off the root element from the path and return a pointer to the instance of the component holding the root element. but surely that's not -really- the parent when it comes to replacements or siblings. –– this EP.parentPath problem is maybe also related to #5464

@bkrmendy bkrmendy mentioned this issue May 15, 2024
Merged
2 tasks
@bkrmendy bkrmendy linked a pull request May 15, 2024 that will close this issue
Replace root element of component #5681
Merged
2 tasks
@bkrmendy bkrmendy assigned liady and unassigned bkrmendy May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liady liady

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace root element of component concrete-utopia/utopia
4 participants
@Rheeseyb @balazsbajorics @liady @bkrmendy