Remove BeforeSelectWorker #8136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan <chaol@vmware.com>
evanchaoli
force-pushed
the
remove-before-select-worker
branch
from
7e29f53
to
2d5f31f
Compare
Signed-off-by: Evan <chaol@vmware.com>
evanchaoli
force-pushed
the
remove-before-select-worker
branch
from
2d5f31f
to
5c80a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
This is a small refactor.
BeforeSelectWorker()was added purely for having a place to callOnCheckBuildStart(). But ended up thatOnCheckBuildStart()is called in two places. Now, I think it would be better to explicitly callOnCheckBuildStart()in check step rather than wrapping it inBeforeSelectWorker(), so thatBeforeSelectWorker()is no longer needed. Removing it helps reducing code complexity.Notes to reviewer
This is a dirty change yet, I haven't run any test. I'm quickly creating this PR to prevent me from forgetting the idea.
Release Note