Webauthn login support #1376
Draft
Webauthn login support #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.lockClick to show 126 changes in this composer.lock filePackage changes
Dev Package changes
Settings · Docs · Powered by Private Packagist |
stof
reviewed
May 12, 2023
| $publicKeyCredentialSource->getCounter() | ||
| ); | ||
| } | ||
| parent::saveCredentialSource($publicKeyCredentialSource); |
There was a problem hiding this comment.
shouldn't this forward the $flush parameter ? Otherwise, it is useless
There was a problem hiding this comment.
The parent already calls the flush method
There was a problem hiding this comment.
Ah, the parent does not have this argument at all. So why adding it in the child class without using it ?
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
|
Hi @stof, Many thanks for the first comments. |
|
Hello, I have two questions
Is there anything I missed (env var or something else)?
#[ORM\Column(type: 'string', name: 'user_handle', length: 200, nullable: true, unique: true)]
private ?string $userHandle = null;Many thanks. |
94noni
reviewed
Jun 24, 2023
| @@ -20,4 +20,6 @@ | |||
| SymfonyCasts\Bundle\VerifyEmail\SymfonyCastsVerifyEmailBundle::class => ['all' => true], | |||
| KnpU\OAuth2ClientBundle\KnpUOAuth2ClientBundle::class => ['all' => true], | |||
| Scheb\TwoFactorBundle\SchebTwoFactorBundle::class => ['all' => true], | |||
| SpomkyLabs\CborBundle\SpomkyLabsCborBundle::class => ['all' => true], | |||
| Webauthn\Bundle\WebauthnBundle::class => ['all' => true], | |||
There was a problem hiding this comment.
i see that you need on twig files templates/user/login.html.twig & templates/user/manage_authenticators.html.twig some javascript, than seems to be kind of generic no?
maybe the bundle can provide them?
a raw js file (or perhaps a stimulus controller)
| "d3": "^3.5.17", | ||
| "instantsearch.js": "^2.7.4", | ||
| "instantsearch.js": "^4.56.0", |
There was a problem hiding this comment.
is this required with your PR?
| public function manage(): Response | ||
| { | ||
| $user = $this->getUser(); | ||
| !$user instanceof User || $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY'); |
There was a problem hiding this comment.
what about #[CurrentUser] User $user in the manage() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at adding Webauthn login.
Webauthn is a web standard that allows the use of strong public key-based credentials for user authentication.
It is proposed in reaction of the recent issue where authentication failure is a key point for such attacks.